Patch Set 4: (4 comments)
https://gerrit.osmocom.org/#/c/6619/4//COMMIT_MSG Commit Message: Line 12: Depends on libosmocore Change-Id Ib79cdb62d45d8c78445c7b064e58eb7e9faeccf9 Related: OS#2184 https://gerrit.osmocom.org/#/c/6619/4/CommonLibs/debug.c File CommonLibs/debug.c: Line 9: .description = "Transciever", _ei_ not _ie_ because its receiver, not reciever and "Transceiver" is from Transmitter + Receiver. https://gerrit.osmocom.org/#/c/6619/4/CommonLibs/debug.h File CommonLibs/debug.h: Line 7: DTRX, I'm honestly not sure if it makes sense to start a category with this name. The program is called "OsmoTRX/Trnsceiver", it implements one or multiple GSM TRXs, but then only the lower layers of it. What exactly wold go in here? I think it makes sense to straight ahead add meaningful categories for idividual code sub-sections. And if you must add a global one, I would simply call it DMAIN or DGLOBAL or DMISC or whatever... https://gerrit.osmocom.org/#/c/6619/4/CommonLibs/trx_vty.c File CommonLibs/trx_vty.c: Line 138: "Copyright (C) 2013 Thomas Tsou <t...@tsou.cc>\r\n" I think this should state all major copyright holders. Doing some research on the Copyright statements in the source, there is: * FSF * Ettus * Tom Tsou * sysmocom I guess we can leave out the folling names: * Range (only GSMCommon.cpp that is *very* small, and Logger.cpp, which we will no longer use?) * Kestrel (only in LogTest.cpp, which is not part of the binary program that prints the above message * Alexander Chemersi (only copyright claim is in PRBSTest.cpp, whcih is also not part of the osmo-trx binary) -- To view, visit https://gerrit.osmocom.org/6619 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08982c37b4f873966304b3cfb38a10ee86eb3dad Gerrit-PatchSet: 4 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-HasComments: Yes
