Patch Set 4: (2 comments)
https://gerrit.osmocom.org/#/c/6619/4/CommonLibs/debug.c File CommonLibs/debug.c: Line 9: .description = "Transciever", > _ei_ not _ie_ because its receiver, not reciever and "Transceiver" is from Typo indeed :-) https://gerrit.osmocom.org/#/c/6619/4/CommonLibs/debug.h File CommonLibs/debug.h: Line 7: DTRX, > I'm honestly not sure if it makes sense to start a category with this name. I don't want to add even more changes to a lot of lines now to set different categories for each log line, so I'll use DMAIN for now and future commits can work on this. -- To view, visit https://gerrit.osmocom.org/6619 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08982c37b4f873966304b3cfb38a10ee86eb3dad Gerrit-PatchSet: 4 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-HasComments: Yes
