Attention is currently required from: laforge, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email )
Change subject: Add DSCP configuration support for server transport role ...................................................................... Patch Set 4: (2 comments) File src/ss7_xua_srv.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/8b958d04_db357903?usp=email : PS3, Line 408: osmo_stream_srv_link_set_ip_dscp(xs->server, xs->cfg.ip_dscp); > xs->server may actually be NULL, so you need to early return in that case. It can't be NULL, when called from VTY, because the L_CS7_XUA_NODE, from which it is called, is only entered when the server has been created. But in case this function is used somewhere else in the future, I added a check. File src/ss7_xua_srv_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/08c01b52_9f2c552f?usp=email : PS3, Line 152: "ip-dscp " IP_DSCP_RANGE_STR, > As mentioned in IM, this should be "init-ip-dscp". Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I35eab3672157c318616f51ee3042243aed263d4e Gerrit-Change-Number: 42807 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 03 Jun 2026 09:32:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
