Attention is currently required from: Hoernchen. dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43172?usp=email )
Change subject: GP: LOAD/STORE DATA chunk size from SCP overhead ...................................................................... Patch Set 1: Code-Review+2 Verified+1 (3 comments) Patchset: PS1: I read through the patch and to me it looks plausible. I also gave it a quick manual test by installing a JAVA applet, which requires SCP02. Before this patch it does not work with Security Level 3, after applying the patch it works with Security Level 3 as well. So I can confirm it works. File pySim/global_platform/__init__.py: https://gerrit.osmocom.org/c/pysim/+/43172/comment/90e5995d_52c3b813?usp=email : PS1, Line 871: load_parser.add_argument('--chunk-len', type=auto_uint8, default=None, (cosmetic, no blocker) as far as I know the default is always None, no need to set it explicitly. File pySim/global_platform/scp.py: https://gerrit.osmocom.org/c/pysim/+/43172/comment/55117bb9_dd23d59e?usp=email : PS1, Line 195: # is one byte less than the largest block-size multiple within 255 - mac_len. Would be nice to have a spec reference here (for the interested reader). -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43172?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic208f3959a38896f64fb6ccefb24cc360a3ac3a2 Gerrit-Change-Number: 43172 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: Hoernchen <[email protected]> Gerrit-Comment-Date: Fri, 07 Aug 2026 09:16:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
