Attention is currently required from: dexter, laforge. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43172?usp=email )
Change subject: GP: LOAD/STORE DATA chunk size from SCP overhead ...................................................................... Patch Set 2: (2 comments) File pySim/global_platform/__init__.py: https://gerrit.osmocom.org/c/pysim/+/43172/comment/b9400ec7_a4658458?usp=email : PS1, Line 871: load_parser.add_argument('--chunk-len', type=auto_uint8, default=None, > (cosmetic, no blocker) as far as I know the default is always None, no need > to set it explicitly. I wanted to make sure that auto uint8 as None is a deliberate default, not accidental implicit None. File pySim/global_platform/scp.py: https://gerrit.osmocom.org/c/pysim/+/43172/comment/1fba4d61_33286b2f?usp=email : PS1, Line 195: # is one byte less than the largest block-size multiple within 255 - mac_len. > Would be nice to have a spec reference here (for the interested reader). there you go, it's just standard aes... -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43172?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic208f3959a38896f64fb6ccefb24cc360a3ac3a2 Gerrit-Change-Number: 43172 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Fri, 07 Aug 2026 11:51:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <[email protected]>
