Attention is currently required from: daniel, laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008?usp=email )
Change subject: TCAP: implement fallback routing when no TCAP ASP can be found. ...................................................................... Patch Set 4: (7 comments) File src/ss7_as_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/5b0af32c_04fe604a?usp=email : PS4, Line 269: "When receiving a TCAP Continue/End/Abort message where no ASP can be assosiated (either via session tracking or by TCAP range for dtid). How should this message handled.\n" "associated" "message handled" -> "message be handled". https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/d065d92d_9f7b7381?usp=email : PS4, Line 547: const char *tcap_unroutable_str = get_value_string_or_null(osmo_ss7_as_tcap_unroutable_vals, This only makes sense in SS7_AS_TCAP_UNROUTABLE_ROUTE_FALLBACK case afaiu, so better move this lookup inside the switch case. File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/113492a3_e1c50678?usp=email : PS3, Line 510: rc = -ENOKEY; > this is quite ugly. […] Not sure what you mean. File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/60bf50e7_e510f7d3?usp=email : PS4, Line 469: struct osmo_mtp_transfer_param new_mtp = {}; since you are copying orig_mtp just below, there's no need to zero-initialize the struct here. https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/3a007a7b_1c3a3a6a?usp=email : PS4, Line 478: /*! When a TCAP MSU from an ongoing session (TCAP != Begin) could not routed either by the TCAP session tracking or could not be routed. https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/80ad141d_c6d7b5ef?usp=email : PS4, Line 504: /* No ASP selection because the SCCP msg will be routed else where */ elsewhere https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/7364ba26_7bf043a5?usp=email : PS4, Line 506: /* Message is handled and will be routed elsewhere */ afaiu this comment is misleading, since case "rc" is actually an error and the message is not being routed? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3e4e634b38a1845c2ce62a3805ff91a530520d88 Gerrit-Change-Number: 43008 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Mon, 10 Aug 2026 08:26:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <[email protected]>
