Attention is currently required from: daniel, laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008?usp=email )
Change subject: TCAP: implement fallback routing when no TCAP ASP can be found. ...................................................................... Patch Set 5: (5 comments) File src/ss7_as_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/25f65af5_63fc2d08?usp=email : PS4, Line 269: "When receiving a TCAP Continue/End/Abort message where no ASP can be assosiated (either via session tracking or by TCAP range for dtid). How should this message handled.\n" > "associated" […] Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/47496a2c_18a1b123?usp=email : PS4, Line 547: const char *tcap_unroutable_str = get_value_string_or_null(osmo_ss7_as_tcap_unroutable_vals, > This only makes sense in SS7_AS_TCAP_UNROUTABLE_ROUTE_FALLBACK case afaiu, so > better move this looku […] No, it is also used by LOAD_SHARE_AS. File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/db6de5f8_5994f407?usp=email : PS4, Line 469: struct osmo_mtp_transfer_param new_mtp = {}; > since you are copying orig_mtp just below, there's no need to zero-initialize > the struct here. Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/40e2431d_633f5094?usp=email : PS4, Line 478: /*! When a TCAP MSU from an ongoing session (TCAP != Begin) could not routed either by the TCAP session tracking or > could not be routed. Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/7a4b63c6_63837fb0?usp=email : PS4, Line 504: /* No ASP selection because the SCCP msg will be routed else where */ > elsewhere Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3e4e634b38a1845c2ce62a3805ff91a530520d88 Gerrit-Change-Number: 43008 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Mon, 10 Aug 2026 15:00:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
