Attention is currently required from: dexter, laforge.

jolly has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/onomondo-ipa/+/43054?usp=email )

Change subject: V1.2: Add function ES10b.GetConnectivityParameters
......................................................................


Patch Set 8:

(2 comments)

File src/ipa/libipa/ipad.c:

https://gerrit.osmocom.org/c/onomondo-ipa/+/43054/comment/54c0eef1_1a1631cb?usp=email
 :
PS7, Line 366:                                                    
res->res->choice.connectivityParameters.httpParams->buf);
> maybe the sheer absence of httpParams is not an error. Its an optional 
> fields. […]
Done


https://gerrit.osmocom.org/c/onomondo-ipa/+/43054/comment/775159a8_18a28b38?usp=email
 :
PS7, Line 369:  }
> maybe it makes sense to evaluate the 
> GetConnectivityParametersResponse_PR_connectivityParametersErro […]
Done



--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43054?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I075590e095dbbe05fa6cdb0a96d5b38c7a17ff78
Gerrit-Change-Number: 43054
Gerrit-PatchSet: 8
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Fri, 21 Aug 2026 13:15:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <[email protected]>

Reply via email to