Attention is currently required from: jolly.

dexter has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/onomondo-ipa/+/43054?usp=email )

Change subject: V1.2: Add function ES10b.GetConnectivityParameters
......................................................................


Patch Set 9: Code-Review+1

(1 comment)

File src/ipa/libipa/ipad.c:

https://gerrit.osmocom.org/c/onomondo-ipa/+/43054/comment/fd63a29f_9e15eb51?usp=email
 :
PS9, Line 376:          ;
I would recommend a log message like you did in 
https://gerrit.osmocom.org/c/onomondo-ipa/+/43055/8/src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c

IPA_LOGP_ESIPA("GetConnectivityParametersRequest", LERROR, "empty 
GetConnectivityParametersResponse response!\n");



--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43054?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I075590e095dbbe05fa6cdb0a96d5b38c7a17ff78
Gerrit-Change-Number: 43054
Gerrit-PatchSet: 9
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Comment-Date: Wed, 26 Aug 2026 10:39:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to