dexter has submitted this change. (
https://gerrit.osmocom.org/c/onomondo-eim/+/42949?usp=email )
Change subject: esipa_asn1_handler_utils: rename EsipaReq to Debuginfo
......................................................................
esipa_asn1_handler_utils: rename EsipaReq to Debuginfo
The parameter EsipaReq only exists because we pass it as
Debuginfo to mnesia_db_work:finish. Let's rename it to
"Debuginfo" in esipa_asn1_handler_utils as well to make
clear what the purpose of this parameter is.
Change-Id: I8115d382172989b9ef7ae7f97ce39520e3e2dd16
Related: SYS#8100
---
M src/esipa_asn1_handler_utils.erl
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Jenkins Builder: Verified
jolly: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/src/esipa_asn1_handler_utils.erl b/src/esipa_asn1_handler_utils.erl
index f288592..2e4295c 100644
--- a/src/esipa_asn1_handler_utils.erl
+++ b/src/esipa_asn1_handler_utils.erl
@@ -24,7 +24,7 @@
none
end.
-process_euiccPackageResult(Pid, EuiccPackageResult, EsipaReq,
EimTransactionId) ->
+process_euiccPackageResult(Pid, EuiccPackageResult, Debuginfo,
EimTransactionId) ->
WorkBind = fun(Map) ->
case maps:find(eimTransactionId, Map) of
{ok, Value} ->
@@ -83,18 +83,18 @@
[{[{euiccPackageErrorCode, undefinedError}]}]
end,
- mnesia_db_work:finish(Pid, Outcome, EsipaReq).
+ mnesia_db_work:finish(Pid, Outcome, Debuginfo).
% Handle an EuiccPackageResult, this includes everything from the handling of
the work items in mnesia_db, down to
% signature checks and the generation of an appropriate outcome for the REST
API.
-handle_euiccPackageResult(Pid, EuiccPackageResult, EsipaReq) ->
+handle_euiccPackageResult(Pid, EuiccPackageResult, Debuginfo) ->
EimTransactionId =
eimTransactionId_from_euiccPackageResult(EuiccPackageResult),
{EidValue, _, _} = mnesia_db_work:pickup(Pid, EimTransactionId),
case crypto_utils:verify_euiccPackageResultSigned(EuiccPackageResult,
EidValue) of
ok ->
- process_euiccPackageResult(Pid, EuiccPackageResult, EsipaReq,
EimTransactionId);
+ process_euiccPackageResult(Pid, EuiccPackageResult, Debuginfo,
EimTransactionId);
_ ->
mnesia_db_work:finish(
- Pid, [{[{procedureError, euiccSignatureInvalid}]}], EsipaReq
+ Pid, [{[{procedureError, euiccSignatureInvalid}]}], Debuginfo
)
end.
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42949?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I8115d382172989b9ef7ae7f97ce39520e3e2dd16
Gerrit-Change-Number: 42949
Gerrit-PatchSet: 11
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: jolly <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
