Attention is currently required from: fixeria, lynxis lazus, osmith, pespin.
Hello Jenkins Builder, fixeria, lynxis lazus, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-msc/+/43433?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by pespin
Change subject: vlr: send RAT type in GSUP ULR
......................................................................
vlr: send RAT type in GSUP ULR
In 2019 fields have been added to GSUP that allow communicating the RAT
type in the Update Location Request. Harald said in [1]:
"MSC/VLR and SGSN should include the "Used RAT Type" IE to indicate the
currently used RAT Type"
When using PyHSS instead of OsmoHLR, this field gets used to check if
the subscriber is restricted to specific RAT types [2]. If it is not
set, the following warning gets logged:
[WARN] No RAT type received in ULR, checking both 2G and 3G RAT restrictions
Fill the field to implement in part what was planned earlier and to get
rid of the warning.
[1]:
https://gerrit.osmocom.org/c/libosmocore/+/12452/4#message-0cd1b05a9c82e304a3d95323dcced6eedbb57988
[2]: https://github.com/nickvsnetworking/pyhss/pull/283
Related: libosmocore I93850710ab55a605bf61b95063a69682a2899bb1
Change-Id: Ia290f483fb5a564396e7665a7eebe633db93ee65
---
M src/libvlr/vlr.c
M tests/msc_vlr/msc_vlr_test_authen_reuse.err
M tests/msc_vlr/msc_vlr_test_call.err
M tests/msc_vlr/msc_vlr_test_gsm_authen.err
M tests/msc_vlr/msc_vlr_test_gsm_ciph.err
M tests/msc_vlr/msc_vlr_test_hlr_reject.err
M tests/msc_vlr/msc_vlr_test_hlr_timeout.err
M tests/msc_vlr/msc_vlr_test_ms_timeout.err
M tests/msc_vlr/msc_vlr_test_no_authen.err
M tests/msc_vlr/msc_vlr_test_reject_concurrency.err
M tests/msc_vlr/msc_vlr_test_rest.err
M tests/msc_vlr/msc_vlr_test_ss.err
M tests/msc_vlr/msc_vlr_test_umts_authen.err
13 files changed, 73 insertions(+), 69 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/33/43433/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43433?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ia290f483fb5a564396e7665a7eebe633db93ee65
Gerrit-Change-Number: 43433
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
