Attention is currently required from: fixeria, lynxis lazus, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/43433?usp=email )
Change subject: vlr: send RAT type in GSUP ULR ...................................................................... Patch Set 2: Code-Review+2 (2 comments) Patchset: PS2: 1 + 1 = 2 (Pau already voted +1 before I updated the commit message slightly) PS2: > This may cause some TTCN-3 tests to fail, because our GSUP templates are not > flexible enough to matc […] Ack. I ran the whole msc ttcn3 testsuite with this patch and almost had the same result as in the `ttcn3-msc-test` jenkins job. `<testsuite name='Titan' tests='240' failures='6' errors='0' skipped='0' inconc='0' time='1209.00'>` There was one additional failure in `TC_sgsap_paging_and_nothing` that did not fail in master. But it passed when I ran it separately or in combination with the test before, so it seems to be a race condition and unrelated to the patch here. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43433?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia290f483fb5a564396e7665a7eebe633db93ee65 Gerrit-Change-Number: 43433 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Mon, 31 Aug 2026 07:34:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <[email protected]>
