Patch Set 3: (3 comments)
https://gerrit.osmocom.org/#/c/6230/3/src/osmo_ms_driver/__init__.py File src/osmo_ms_driver/__init__.py: Line 5: # Authors: D. Lazlo Sitzer <[email protected]> > Better use your name here as this subdir is all from you? That's not how copyright works but you have an expert in your proximity but I doubt that this file can be copyrighted at all. https://gerrit.osmocom.org/#/c/6230/3/src/osmo_ms_driver/cdf.py File src/osmo_ms_driver/cdf.py: Line 65: > ws Done Line 89: Linear progression that reaches 100% after duration.total_seconds() > it would make a lot of sense to move this to selftest directory with its ow As a follow-up please. What is the reasoning for it? What is the concern against doctest? -- To view, visit https://gerrit.osmocom.org/6230 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e3064f4c3c4c7af5d3491f850090516e541f4d3 Gerrit-PatchSet: 3 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-HasComments: Yes
