Patch Set 10:

File include/osmocom/bsc/gsm_data.h:

PS10, Line 1280: ;
               :        lai = (struct osmo_location_area_id)
> why not simply have the '=' one line above, no typecast and no need to rest
weird, makes me wonder "what was my motivation"
File src/osmo-bsc/osmo_bsc_vty.c:

Line 242:       
> whitespace, not critical
vim has a way of removing these obsolete tabs, but for some reason it doesn't 
always work. That in combination with my external patch colorizer .. I should 
teach it to also mark whitespace errors.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e722103344186fde118b26d8353db95a4581daa
Gerrit-PatchSet: 10
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <>
Gerrit-Reviewer: Harald Welte <>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <>
Gerrit-HasComments: Yes

Reply via email to