Patch Set 10: (1 comment)
https://gerrit.osmocom.org/#/c/6668/10/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: PS10, Line 1280: ; : lai = (struct osmo_location_area_id) > weird, makes me wonder "what was my motivation" NOW I remember: the lai is static. If I init on the static definition, I fear that it will not be updated in each function call but only once. Maybe it doesn't even work to init statics with function args. -- To view, visit https://gerrit.osmocom.org/6668 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e722103344186fde118b26d8353db95a4581daa Gerrit-PatchSet: 10 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
