Patch Set 3: (1 comment)
https://gerrit.osmocom.org/#/c/7159/3/src/osmo_gsm_tester/bts_osmo.py File src/osmo_gsm_tester/bts_osmo.py: Line 80: def ready_for_pcu(self): > I still disagree and believe non-public member functions should have leadin ready_for_pcu is public so it's fine if it doesn't contain any underscore. >From a test, of course you can call it as the language permits it, but the >function may not be aimed at that purpose. -- To view, visit https://gerrit.osmocom.org/7159 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8978854404897ae5de7e3100d55d86c7a5c1df1 Gerrit-PatchSet: 3 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-HasComments: Yes
