Patch Set 4:
I think this patch is introducing several compiler warnings, in my PC I can see:
/home/pespin/dev/sysmocom/build/new/out/include/osmocom/core/fsm.h:123:38:
warning: too many arguments for format [-Wformat-extra-args]
LOGP((fi)->fsm->log_subsys, level, "%s{%s}: " fmt, \
^
/home/pespin/dev/sysmocom/build/new/out/include/osmocom/core/logging.h:93:54:
note: in definition of macro ‘LOGPSRCC’
logp2(ss, level, caller_file, caller_line, cont, fmt, ##args); \
^~~
/home/pespin/dev/sysmocom/build/new/out/include/osmocom/core/logging.h:47:2:
note: in expansion of macro ‘LOGPSRC’
LOGPSRC(ss, level, NULL, 0, fmt, ## args)
^~~~~~~
/home/pespin/dev/sysmocom/build/new/out/include/osmocom/core/fsm.h:123:3: note:
in expansion of macro ‘LOGP’
LOGP((fi)->fsm->log_subsys, level, "%s{%s}: " fmt, \
^~~~
/home/pespin/dev/sysmocom/git/osmo-bsc/src/libbsc/bsc_subscr_conn_fsm.c:372:4:
note: in expansion of macro ‘LOGPFSML’
LOGPFSML(fi, LOGL_ERROR, "Requested channel mode is not supported!\n",
^~~~~~~~
/home/pespin/dev/sysmocom/build/new/out/include/osmocom/core/fsm.h:123:38:
warning: too many arguments for format [-Wformat-extra-args]
LOGP((fi)->fsm->log_subsys, level, "%s{%s}: " fmt, \
^
/home/pespin/dev/sysmocom/build/new/out/include/osmocom/core/logging.h:95:53:
note: in definition of macro ‘LOGPSRCC’
logp2(ss, level, __BASE_FILE__, __LINE__, cont, fmt, ##args); \
^~~
/home/pespin/dev/sysmocom/build/new/out/include/osmocom/core/logging.h:47:2:
note: in expansion of macro ‘LOGPSRC’
LOGPSRC(ss, level, NULL, 0, fmt, ## args)
^~~~~~~
/home/pespin/dev/sysmocom/build/new/out/include/osmocom/core/fsm.h:123:3: note:
in expansion of macro ‘LOGP’
LOGP((fi)->fsm->log_subsys, level, "%s{%s}: " fmt, \
^~~~
/home/pespin/dev/sysmocom/git/osmo-bsc/src/libbsc/bsc_subscr_conn_fsm.c:372:4:
note: in expansion of macro ‘LOGPFSML’
LOGPFSML(fi, LOGL_ERROR, "Requested channel mode is not supported!\n",
^~~~~~~~
------------------
/home/pespin/dev/sysmocom/git/osmo-bsc/tests/handover/handover_test.c:48:83:
warning: ‘struct mgcp_conn_peer’ declared inside parameter list will not be
visible outside of this definition or declaration
int __real_mgcp_conn_modify(struct osmo_fsm_inst *fi, uint32_t parent_evt,
struct mgcp_conn_peer *conn_peer);
^~~~~~~~~~~~~~
/home/pespin/dev/sysmocom/git/osmo-bsc/tests/handover/handover_test.c:49:83:
warning: ‘struct mgcp_conn_peer’ declared inside parameter list will not be
visible outside of this definition or declaration
int __wrap_mgcp_conn_modify(struct osmo_fsm_inst *fi, uint32_t parent_evt,
struct mgcp_conn_peer *conn_peer)
--
To view, visit https://gerrit.osmocom.org/7142
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68286d26e2014048b054f39ef29c35fef420cc97
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-HasComments: No
