Patch Set 5: (5 comments)
> mh. I thought we didn't expect any regressions in the tests > according to pmaier? > https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-bsc-test/test_results_analyzer/ > says something else: 8 testcases fail which passed before the merge > :( It is strange that it fails on the jenkins, while it works for me locally. I managed to reproduce the probelms we see around the paging tests, but the assignment and the handover tests seem to work fine. I have updated the ticked with latest overview: https://osmocom.org/issues/2823 https://gerrit.osmocom.org/#/c/7142/3/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: PS3, Line 190: user_plane; : }; : : : /* 16 is the max. number of SI2quater messages according to 3GPP TS 44.018 Table 10.5.2.33b.1: : 4-bit index is used (2#1111 = 10#15) */ : #define SI2Q_MAX_NUM 16 : /* length in bits (for single SI2qua > In a patch of mine I have actually made these obsolete, by moving into conn I have removed the members now, still compiles just fine. https://gerrit.osmocom.org/#/c/7142/3/src/libbsc/bsc_subscr_conn_fsm.c File src/libbsc/bsc_subscr_conn_fsm.c: Line 246: /* FIXME: Extract Mobile ID and update FSM using osmo_fsm_inst_set_id() > related: https://osmocom.org/issues/2969, i.e. we will probably extract the Done Line 265: osmo_sccp_tx_disconn(conn->sccp.msc->a.sccp_user, scu_prim->u.connect.conn_id, > related: https://osmocom.org/issues/2969 (same as above) Done Line 322: /* FIXME: At the moment, the FSM is constructed in an > should still be restructured? We decided not to this with this commit. Its more a cosmetic thing. https://gerrit.osmocom.org/#/c/7142/3/tests/handover/handover_test.c File tests/handover/handover_test.c: Line 63: * parent_evt back to the GSCON FSM in order to make it think that the > "normally", the fi is of course populated, just in this artificial test set Done -- To view, visit https://gerrit.osmocom.org/7142 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68286d26e2014048b054f39ef29c35fef420cc97 Gerrit-PatchSet: 5 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-HasComments: Yes
