Patch Set 1: +1 for using osmo_auth_c3() instead of code dup'ing.
SQN: in milenage, we mostly handle it as an integer value in a uint64_t, but see in milenage_gen_vec(), we use osmo_store64be_ext(next_sqn, sqn, 6); Likely this should do the same here. -- To view, visit https://gerrit.osmocom.org/7310 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1afaf0a9e2dce43aec87964bacefb21ed4d3d565 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-HasComments: No
