Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/7555/1/include/osmocom/mgcp/mgcp_internal.h
File include/osmocom/mgcp/mgcp_internal.h:

Line 207:       struct rate_ctr_group_desc rate_ctr_group_desc;
the rate_ctr_group_desc and rate_ctr_desc should be global data (if not even 
const?).  Wat is the rationale of copying it into each and every mgcp_state?  
Only the "rate_ctr_group *" should be here, AFAICT.


https://gerrit.osmocom.org/#/c/7555/1/src/libosmo-mgcp/mgcp_conn.c
File src/libosmo-mgcp/mgcp_conn.c:

Line 119:           talloc_strdup(conn, "conn_rtp");
all of those strings should be static/const strings, no copying or dynamic 
allocations involved.  Did you check existing examples about how we use 
rate_ctr in the osmocom code?  If there are any examples like thism, please let 
me know, as we need to fix it.


-- 
To view, visit https://gerrit.osmocom.org/7555
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67aa7a8602f60366ef3ba2c5b1319b1b85719f64
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes

Reply via email to