Review at https://gerrit.osmocom.org/7837
BSC_Tests: handle mode modify also for signalling
The Altstep as_modify() is designed to work only with assignments
that assign a voice call (st.voice_call must be true). Howeber, it
should also work on assignments that assign a signalling channel
only.
- Remove the test on st.voice_call from the guard statement of
the two altsteps.
Change-Id: Ie0e5f15c1a13b773a7693918942e7ff92dfb99d6
Related: OS#2762
---
M bsc/MSC_ConnectionHandler.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/37/7837/1
diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn
index e648427..71ad1f2 100644
--- a/bsc/MSC_ConnectionHandler.ttcn
+++ b/bsc/MSC_ConnectionHandler.ttcn
@@ -578,7 +578,7 @@
/* no assignment, just mode modify */
var RSL_Message rsl;
- [st.voice_call and not st.rr_modify_seen]
RSL.receive(tr_RSL_DATA_REQ(g_chan_nr)) -> value rsl {
+ [not st.rr_modify_seen] RSL.receive(tr_RSL_DATA_REQ(g_chan_nr)) ->
value rsl {
var PDU_ML3_NW_MS l3 :=
dec_PDU_ML3_NW_MS(rsl.ies[2].body.l3_info.payload);
log("Rx L3 from net: ", l3);
if (ischosen(l3.msgs.rrm.channelModeModify)) {
@@ -588,7 +588,7 @@
}
repeat;
}
- [st.voice_call and st.rr_modify_seen]
RSL.receive(tr_RSL_MsgTypeD(RSL_MT_MODE_MODIFY_REQ)) -> value rsl {
+ [st.rr_modify_seen]
RSL.receive(tr_RSL_MsgTypeD(RSL_MT_MODE_MODIFY_REQ)) -> value rsl {
RSL.send(ts_RSL_MODE_MODIFY_ACK(g_chan_nr));
st.modify_done := true;
repeat;
--
To view, visit https://gerrit.osmocom.org/7837
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0e5f15c1a13b773a7693918942e7ff92dfb99d6
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: dexter <[email protected]>
