Patch Set 1: Code-Review-1

why would we want a MODE MODIFY handling in a pure signaling assignment?  What 
kind of modification is performed there?  The channel is in SIGNALING mode from 
the point of immediate assignment onwards, and it still is in SIGNALING mode at 
the time we receive an assignment command (sign).  So in this situation the 
expectation is that there's no modification (that would be signalling->speech) 
and no assignment (as that would change to a different channel).  So all in 
all, there should just be BSSAP ASS CMD and BSSAP ASS CMPL with nothing 
happening at all on the RSL side.  Please correct me if you think differenly

-- 
To view, visit https://gerrit.osmocom.org/7837
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0e5f15c1a13b773a7693918942e7ff92dfb99d6
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

Reply via email to