Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9211 )
Change subject: implement periodic Location Update expiry in the VLR ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/#/c/9211/2/src/libvlr/vlr.c File src/libvlr/vlr.c: https://gerrit.osmocom.org/#/c/9211/2/src/libvlr/vlr.c@469 PS2, Line 469: /* Table 10.5.33: The T3212 timeout value is coded as the > This comment was moved here, I didn't write it. […] no no, I was just mocking about the design from 3GPP. But the comment is actually helpful. Let's just fix the spec reference. I can find half of it at 3GPP TS 24.008 Table 10.5.1.12.2, and 3GPP TS 44.018 Table 10.5.2.11.1; but so far can't find this "Table 10.5.33" nor the spec to use twice T3212 plus 1 minute... can anyone else find it? https://gerrit.osmocom.org/#/c/9211/2/src/libvlr/vlr.c@1144 PS2, Line 1144: /* See TS 32.012 version 9.10.0 4.3.2.1 "Process Detach_IMSI_VLR" */ 23.012 ! https://gerrit.osmocom.org/#/c/9211/2/src/libvlr/vlr.c@1192 PS2, Line 1192: osmo_timer_setup(&vlr->lu_expire_timer, vlr_subscr_expire_lu, vlr); > It's not in the same function. […] yes, I saw that, but it doesn't make sense to setup the timer if it isn't started, so might as well setup in vlr_start() as well. Usually when I read code, I see a timer being started with the related callback function referenced right next to it. Makes it harder to read if that is spread about. So it's a cosmetic preference. Any hard reason to need this in vlr_alloc()? -- To view, visit https://gerrit.osmocom.org/9211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebdee8b12d22acfcfb265ee41e71cfc8d9eb3ba9 Gerrit-Change-Number: 9211 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Comment-Date: Fri, 18 May 2018 12:47:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
