Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9394 )
Change subject: GGSN_Tests: test what happens when PCO contains only one DNS entry ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/9394/1/ggsn_tests/GGSN_Tests.ttcn File ggsn_tests/GGSN_Tests.ttcn: https://gerrit.osmocom.org/#/c/9394/1/ggsn_tests/GGSN_Tests.ttcn@950 PS1, Line 950: f_pdp_ctx_del(ctx, '1'B); I think it would make sense to also check that the response is valid (that we received the expected DNS values, like other tests do). It also makes sense to check the case in which we sent a PCO with two IPCP, one with Primary DNS and another with a Secondary DNS. Basically what we saw the BlackBerry is doing. Then check that both DNS values are correct when answered. https://gerrit.osmocom.org/#/c/9394/1/ggsn_tests/GGSN_Tests.ttcn@969 PS1, Line 969: execute(TC_pdp4_act_deact_with_single_dns()); Please move it together with the other TC_pdp4 ones. https://gerrit.osmocom.org/#/c/9394/1/ggsn_tests/expected-results.xml File ggsn_tests/expected-results.xml: https://gerrit.osmocom.org/#/c/9394/1/ggsn_tests/expected-results.xml@14 PS1, Line 14: <testcase classname='GGSN_Tests' name='TC_pdp4_act_deact_with_single_dns' time='MASKED'/> Same here. -- To view, visit https://gerrit.osmocom.org/9394 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71761e1f9db7ceac3c3df43d2e539f8c8d53c4fc Gerrit-Change-Number: 9394 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Wed, 30 May 2018 15:47:23 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
