Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9394 )
Change subject: GGSN_Tests: test what happens when PCO contains only one DNS entry ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/9394/2/ggsn_tests/GGSN_Tests.ttcn File ggsn_tests/GGSN_Tests.ttcn: https://gerrit.osmocom.org/#/c/9394/2/ggsn_tests/GGSN_Tests.ttcn@964 PS2, Line 964: pco_neg_dns_expected := '0200000A8306'O & ggsn_ip4_dns2 What's this hardcoded hex string here for? -- To view, visit https://gerrit.osmocom.org/9394 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71761e1f9db7ceac3c3df43d2e539f8c8d53c4fc Gerrit-Change-Number: 9394 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Thu, 05 Jul 2018 11:21:21 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
