Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9402 )

Change subject: gb_proxy: Add ctrl interface and ns-state, gbproxy-state 
commands
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/9402/2//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/9402/2//COMMIT_MSG@23
PS2, Line 23: Got message: b'ERROR 23 No peers found'
it's debatable if no peers is actually an "ERROR" in the context of the CTRL 
interface.  I would argue the operation as successful but rendered 0 results.  
But then, as indicated, debatable :)



--
To view, visit https://gerrit.osmocom.org/9402
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82c74fd0bfcb9ba4ec3619d9fdaa0cae201b3177
Gerrit-Change-Number: 9402
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Tue, 05 Jun 2018 17:32:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to