daniel has posted comments on this change. ( https://gerrit.osmocom.org/9402 )
Change subject: gb_proxy: Add ctrl interface and nsvc-state, gbproxy-state commands ...................................................................... Patch Set 4: (2 comments) Needs https://gerrit.osmocom.org/#/c/libosmocore/+/9631/ to pass https://gerrit.osmocom.org/#/c/9402/3/src/gprs/gb_proxy_ctrl.c File src/gprs/gb_proxy_ctrl.c: https://gerrit.osmocom.org/#/c/9402/3/src/gprs/gb_proxy_ctrl.c@47 PS3, Line 47: > This might be taking it a bit too far, but I think it makes sense to have the > "convert a NSVC to a C […] Sounds good. Patch is in https://gerrit.osmocom.org/#/c/libosmocore/+/9631/ https://gerrit.osmocom.org/#/c/9402/3/src/gprs/gb_proxy_ctrl.c@61 PS3, Line 61: cmd->reply = talloc_strdup(cmd, ""); > as we're printing NSVC state, I think it might also make sense to call the > command "nsvc-state". […] Done. I also changed the function names to align with the command names. -- To view, visit https://gerrit.osmocom.org/9402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82c74fd0bfcb9ba4ec3619d9fdaa0cae201b3177 Gerrit-Change-Number: 9402 Gerrit-PatchSet: 4 Gerrit-Owner: daniel <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Comment-Date: Thu, 14 Jun 2018 15:48:19 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
