Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9753 )

Change subject: rate_ctr: Improve logging
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/9753/3//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/9753/3//COMMIT_MSG@10
PS3, Line 10: rate_ctr groups made it difficult to debug when an issue occurrs.
can you elaborate here in the commitlog?  I see what your patch is doing, but I 
fail to understand why.  The "quiet" logic was introduced in order to not 
splatter the log files with messages about mangled counter names in "normal" 
use cases.



--
To view, visit https://gerrit.osmocom.org/9753
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I992d165cab5ee6ca9b5b7e4a2210a0951954bd34
Gerrit-Change-Number: 9753
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-CC: Harald Welte <lafo...@gnumonks.org>
Gerrit-Comment-Date: Thu, 12 Jul 2018 18:52:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to