Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9753 )
Change subject: rate_ctr: Improve logging ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/9753/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/9753/3//COMMIT_MSG@10 PS3, Line 10: rate_ctr groups made it difficult to debug when an issue occurrs. > can you elaborate here in the commitlog? I see what your patch is doing, but > I fail to understand w […] Most users of this API already got the naming of the counters fixed nowadays, so it's better to log the ones still requiring change instead of silently mangling them. I ended up doing this patch in order to figure out what was going on and fixing some rate_ctr API caller issues in some other project, because if I remember correctly the fact of mangling names after the hood was preventing me to understand easily what was going on and finding how to best solve the issue. So I think this patch is going to be useful for people having similar issues in the future to what I had a few weeks ago. -- To view, visit https://gerrit.osmocom.org/9753 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I992d165cab5ee6ca9b5b7e4a2210a0951954bd34 Gerrit-Change-Number: 9753 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Fri, 20 Jul 2018 09:49:09 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
