Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9979 )
Change subject: nat: ctrl: use strtol instead of atoi as it has explicit error documentation ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/9979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief0b203efbcf2be04253b5056840be94d58a9994 Gerrit-Change-Number: 9979 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 13 Jul 2018 05:01:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes