Neels Hofmeyr has uploaded this change for review. (
https://gerrit.osmocom.org/9998
Change subject: bsc: fix f_gen_ass_req(): populate codec list
......................................................................
bsc: fix f_gen_ass_req(): populate codec list
f_gen_ass_req() looks like it generates a valid assignment request, but
actually lacks the Speech Codec List IE.
At least the following tests dispatch an erratic Assignment Request and expect
failure, but were so far failing just because the Speech Codec List IE was
missing:
* TC_assignment_csd()
* TC_assignment_ctm()
The same bit me when I was trying to add TC_assignment_chan_act_nack().
Rather set some default codec list in f_gen_ass_req(). Callers that explicitly
want a specific or omitted Speech Codec List (e.g.
TC_assignment_fr_a5_1_codec_missing()) may still modify the returned template.
Change-Id: Ia18e44e93b0328ad26d741a3317753118fc57f9f
---
M bsc/BSC_Tests.ttcn
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/98/9998/1
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 2897a0b..f407e58 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -572,6 +572,7 @@
var BSSMAP_IE_CircuitIdentityCode cic :=
valueof(ts_BSSMAP_IE_CIC(0,1));
ass_cmd := valueof(ts_BSSMAP_AssignmentReq(cic, omit));
}
+ ass_cmd.pdu.bssmap.assignmentRequest.codecList :=
valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR}));
return ass_cmd;
}
@@ -1630,6 +1631,7 @@
const OCT8 kc := '0001020304050607'O;
ass_cmd.pdu.bssmap.assignmentRequest.channelType :=
valueof(ts_BSSMAP_IE_ChannelType);
+ ass_cmd.pdu.bssmap.assignmentRequest.codecList := omit;
f_establish_fully(ass_cmd, exp_fail);
}
testcase TC_assignment_fr_a5_1_codec_missing() runs on test_CT {
--
To view, visit https://gerrit.osmocom.org/9998
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia18e44e93b0328ad26d741a3317753118fc57f9f
Gerrit-Change-Number: 9998
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <[email protected]>
