Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9998 )
Change subject: bsc: fix f_gen_ass_req(): populate codec list ...................................................................... Patch Set 1: Hmm. CSD and Speech Codec List: I assumed we wanted to see osmo-bsc rejecting on the grounds of it being a CSD, and not on grounds of lacking a speech codec list IE, didn't actually realize that a CSD has no Speech Codecs. Maybe a mandatory flag should enforce that the caller is aware of Speech Codec List presence... I need to take another look. -- To view, visit https://gerrit.osmocom.org/9998 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia18e44e93b0328ad26d741a3317753118fc57f9f Gerrit-Change-Number: 9998 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Wed, 18 Jul 2018 22:08:32 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
