Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10055 )
Change subject: protocol: prevent unnecessary null pointer deref ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/10055/1/include/osmocom/mgcp/mgcp.h File include/osmocom/mgcp/mgcp.h: https://gerrit.osmocom.org/#/c/10055/1/include/osmocom/mgcp/mgcp.h@80 PS1, Line 80: typedef int (*mgcp_processing_setup)(struct mgcp_endpoint *endp, Are you breaking the API with this change? Looks like it does. Please state so in the commit description (compatibility with old apps is broken here). -- To view, visit https://gerrit.osmocom.org/10055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id46e9bfba88613387026639eb4957221cce6820a Gerrit-Change-Number: 10055 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Thu, 19 Jul 2018 16:28:54 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
