Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10055 )
Change subject: protocol: prevent unnecessary null pointer deref ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/10055/1/include/osmocom/mgcp/mgcp.h File include/osmocom/mgcp/mgcp.h: https://gerrit.osmocom.org/#/c/10055/1/include/osmocom/mgcp/mgcp.h@80 PS1, Line 80: typedef int (*mgcp_processing_setup)(struct mgcp_endpoint *endp, > Are you breaking the API with this change? Looks like it does. […] libosmo-mgcp is only used by osmo-mgw itself. In fact, I think for sanity we should simply male it a static library and link it only statically? Also, the call-back functionality here is only used *inside* two modules of libosmo-mgcp, so not even any change to osmo-mgw in this same repository is required. -- To view, visit https://gerrit.osmocom.org/10055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id46e9bfba88613387026639eb4957221cce6820a Gerrit-Change-Number: 10055 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Fri, 20 Jul 2018 05:05:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
