Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10054 )
Change subject: fix unaligned access in build_ipcp_pco() ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/10054/1/ggsn/ggsn.c File ggsn/ggsn.c: https://gerrit.osmocom.org/#/c/10054/1/ggsn/ggsn.c@426 PS1, Line 426: cur_opt += OSMO_MAX(len, 2); > Length 0 and 1 make no sense because the value includes type and length field > (2 bytes). […] "Be liberal in what you accept" doesn't mean assuming a random LEN value if the wrong one was encoded/received. From that point on you may be reading garbage. So I believe what we have here here is not the correct solution. -- To view, visit https://gerrit.osmocom.org/10054 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1410abb216831864042f95679330f4508e1af3d Gerrit-Change-Number: 10054 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Thu, 19 Jul 2018 17:26:28 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
