Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10054 )
Change subject: fix unaligned access in build_ipcp_pco() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/10054/1/ggsn/ggsn.c File ggsn/ggsn.c: https://gerrit.osmocom.org/#/c/10054/1/ggsn/ggsn.c@426 PS1, Line 426: cur_opt += OSMO_MAX(len, 2); > "Be liberal in what you accept" doesn't mean assuming a random LEN value if > the wrong one was encode […] OK, I am convinced now :) The latest patch set rejects short options. It does not log them. I would not want to add a log message that provides no context, and additional parameters would be required to acquire some context for a log message (e.g. PDP context request has the problem). In any case, this part could be improved in a follow-up patch. -- To view, visit https://gerrit.osmocom.org/10054 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1410abb216831864042f95679330f4508e1af3d Gerrit-Change-Number: 10054 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Thu, 19 Jul 2018 17:52:42 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
