Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10024 )
Change subject: gtp: Add new replacement cb_recovery2 for cb_recovery ...................................................................... Patch Set 3: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/10024/3/gtp/gtp.h File gtp/gtp.h: https://gerrit.osmocom.org/#/c/10024/3/gtp/gtp.h@274 PS3, Line 274: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery); ok, so we break ABI but we don't break API compatibility - that's not great but acceptable (and I see little other chances. We could have a union of cb_recovery + cb_recovery2, but then where would we stuff the bit to differentiate which of the two to use? -- To view, visit https://gerrit.osmocom.org/10024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I53e92298f2f6b84d662a3300d922e8c2ccb178bc Gerrit-Change-Number: 10024 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 24 Jul 2018 04:56:36 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
