Neels Hofmeyr has uploaded this change for review. (
https://gerrit.osmocom.org/10129
Change subject: BTS codec pref legacy compat: allow all codecs per default
......................................................................
BTS codec pref legacy compat: allow all codecs per default
Legacy compat: we used to not check the BTS codec-pref settings upon assignment
until we added checks for the BTS codec-pref in osmo-bsc
5bc43cd107597b78f701f77c7fd4cce8f923dce5, change-id
I285234e9c81de74d9fb9907fca2c443b08537435, "codec_pref: check bts codec
support". From that commit onwards, config setups without a 'codec-pref'
potentially stop working (like all osmo-gsm-tester runs just did), because with
no codec-pref settings, now only FR is permitted, while before the patch, we
would allow any codecs as long as MSC and the overall BSC config agree on them.
So, upon BTS initialization, enable all codecs. These get reset to a more fine
grained selection IF a 'codec-pref' appears in the config file (see bsc_vty.c).
Change-Id: I4650a1f8e350c6f74f48391f43ddfe771be01e1b
---
M src/osmo-bsc/gsm_data.c
1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/29/10129/1
diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c
index 0f062d2..6c8bdf3 100644
--- a/src/osmo-bsc/gsm_data.c
+++ b/src/osmo-bsc/gsm_data.c
@@ -757,6 +757,20 @@
INIT_LLIST_HEAD(&bts->abis_queue);
INIT_LLIST_HEAD(&bts->loc_list);
+ /* Legacy compat: we used to not check the BTS codec-pref settings upon
assignment until we added
+ * checks for the BTS codec-pref in osmo-bsc
5bc43cd107597b78f701f77c7fd4cce8f923dce5, change-id
+ * I285234e9c81de74d9fb9907fca2c443b08537435, "codec_pref: check bts
codec support". From that
+ * commit onwards, config setups without a 'codec-pref' potentially
stop working, because with no
+ * codec-pref settings, now only FR is permitted, while before the
patch, we would allow any
+ * codecs as long as MSC and the overall BSC config agree on them. So,
upon BTS initialization,
+ * enable all codecs. These get reset to a more fine grained selection
IF a 'codec-pref' appears
+ * in the config file (see bsc_vty.c). */
+ bts->codec = (struct bts_codec_conf){
+ hr = 1,
+ efr = 1,
+ amr = 1,
+ };
+
return bts;
}
--
To view, visit https://gerrit.osmocom.org/10129
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4650a1f8e350c6f74f48391f43ddfe771be01e1b
Gerrit-Change-Number: 10129
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <[email protected]>
