Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10129 )
Change subject: BTS codec pref legacy compat: allow all codecs per default ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/10129/1/src/osmo-bsc/gsm_data.c File src/osmo-bsc/gsm_data.c: https://gerrit.osmocom.org/#/c/10129/1/src/osmo-bsc/gsm_data.c@767 PS1, Line 767: * in the config file (see bsc_vty.c). */ I think we don't need this huge comment here. Let's only keep the following: /* enable all codecs. These get reset to a more fine grained selection IF a 'codec-support' appears in the config file (see bsc_vty.c). */ Note also I changed codec-pref by codec-support :) -- To view, visit https://gerrit.osmocom.org/10129 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4650a1f8e350c6f74f48391f43ddfe771be01e1b Gerrit-Change-Number: 10129 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 24 Jul 2018 13:05:31 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
