Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10166 )
Change subject: msc: Fix random error of TC_cl3_rnd_payload ...................................................................... Patch Set 1: Code-Review+1 (4 comments) https://gerrit.osmocom.org/#/c/10166/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/10166/1//COMMIT_MSG@9 PS1, Line 9: The random length for that test could to out of bounds leading to a This sentence looks strange to me. Missing word "trigger" or similar after "could"? https://gerrit.osmocom.org/#/c/10166/1/msc/MSC_Tests.ttcn File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/#/c/10166/1/msc/MSC_Tests.ttcn@1158 PS1, Line 1158: // length is limited by PDU_BSSAP length field which includes some Better use /* */ for comments. https://gerrit.osmocom.org/#/c/10166/1/msc/MSC_Tests.ttcn@1159 PS1, Line 1159: // other fields beside l3info payload. So payl can only be 240 bytes be "max" 240 bytes? Why do you use value 241 then? due to accounting the length field too? Would be good to write it down too. https://gerrit.osmocom.org/#/c/10166/1/msc/MSC_Tests.ttcn@1162 PS1, Line 1162: log("Length:", len); We can drop this line. -- To view, visit https://gerrit.osmocom.org/10166 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7be33e261a11f03a80a6b770b6acf0a4be49b85b Gerrit-Change-Number: 10166 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Thu, 26 Jul 2018 08:45:27 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
