Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10328 )
Change subject: libosmogsm: (re)introduce gsm48_push_l3hdr() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/10328/1/src/gsm/gsm48_utils.c File src/gsm/gsm48_utils.c: https://gerrit.osmocom.org/#/c/10328/1/src/gsm/gsm48_utils.c@52 PS1, Line 52: gh->proto_discr = pdisc | (tid << 4); > what if "pdisc" accidentially contains some bits in the lower nibble? I > think it's safer to add a ( […] Yep, makes sense... But after looking at some other messages, which may have no transaction ID, I think it would be more flexible to leave it up to caller, i.e. accept a single value instead of separate pdisc and tid... What do you think? -- To view, visit https://gerrit.osmocom.org/10328 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a045efe8335d83fcbe8d43eb180972e3b1d9dda Gerrit-Change-Number: 10328 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Sun, 05 Aug 2018 11:21:28 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
