Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10328 )
Change subject: libosmogsm: (re)introduce gsm48_push_l3hdr() ...................................................................... Patch Set 2: > we can merge it as-is. However, I'd prefer if we can simply add > the new function to gsm48.c. Why introduce a new file? TBH, I don't remember why I decided to introduce a new file, but now I don't see any problem of doing this in gsm48.c... Will upload the change soon. -- To view, visit https://gerrit.osmocom.org/10328 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a045efe8335d83fcbe8d43eb180972e3b1d9dda Gerrit-Change-Number: 10328 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Sun, 05 Aug 2018 16:07:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
