Neels Hofmeyr has submitted this change and it was merged. (
https://gerrit.osmocom.org/10162 )
Change subject: ipa_asp_fsm: init: expect IPA ID ACK, not GET
......................................................................
ipa_asp_fsm: init: expect IPA ID ACK, not GET
Testing with an actual SCCPlite MSC, I see the IPA connection starting out by
the MSC sending an IPA ID ACK. Make the ipa_asp_fsm match that.
Change-Id: Icffda98579e676ab6ca63c9c22cf5d151c4fe95f
---
M src/xua_asp_fsm.c
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c
index 78a4f25..d6edac0 100644
--- a/src/xua_asp_fsm.c
+++ b/src/xua_asp_fsm.c
@@ -785,7 +785,7 @@
}
} else {
/* Client: We simply wait for an ID GET */
- osmo_fsm_inst_state_chg(fi, IPA_ASP_S_WAIT_ID_GET, 10,
T_WAIT_ID_GET);
+ osmo_fsm_inst_state_chg(fi, IPA_ASP_S_WAIT_ID_ACK, 10,
T_WAIT_ID_ACK);
}
break;
}
@@ -985,7 +985,7 @@
[IPA_ASP_S_DOWN] = {
.in_event_mask = S(XUA_ASP_E_M_ASP_UP_REQ) |
S(XUA_ASP_E_SCTP_EST_IND),
- .out_state_mask = S(IPA_ASP_S_WAIT_ID_GET) |
+ .out_state_mask = S(IPA_ASP_S_WAIT_ID_ACK) |
S(IPA_ASP_S_WAIT_ID_RESP),
.name = "ASP_DOWN",
.action = ipa_asp_fsm_down,
--
To view, visit https://gerrit.osmocom.org/10162
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icffda98579e676ab6ca63c9c22cf5d151c4fe95f
Gerrit-Change-Number: 10162
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
