Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/10699 )
Change subject: cosmetic: lchan activ: no need to clear mr again
......................................................................
Patch Set 1:
> what? :)
>
> Ok, to put it differently, if you see code like this:
>
> x.foo = {};
> x.bar = 1;
> x.baz = 5;
> memset(&x.foo, 0, sizeof(x.foo));
>
> and you remove the final memset because x.foo was already cleared
> before, that for me constitutes a cosmetic code change. We can
> agree at least that there is absolutely no functional difference!?
The result may be the same, but the steps to do so change, like instructions
executed, time spent. Would you consider changing a bubble sort with a
quicksort a cosmetic change too?
The patch is fine, I just get annoyed over time with the high amount of patches
we mark as cosmetic that are actually changing how programs are executed, so I
wanted to share my concerns.
--
To view, visit https://gerrit.osmocom.org/10699
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b38f222f1c8c822e8e5e776850dbc60e30e8b8d
Gerrit-Change-Number: 10699
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-CC: Pau Espin Pedrol <[email protected]>
Gerrit-Comment-Date: Tue, 04 Sep 2018 10:04:02 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
