Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/10699 )
Change subject: cosmetic: lchan activ: no need to clear mr again
......................................................................
cosmetic: lchan activ: no need to clear mr again
In lchan state UNUSED, on activating an lchan, we zero out the lchan->mr_ms_lv
and mr_bts_lv. However, in UNUSED's onenter function, we already called
lchan_reset(), clearing out the lchan completely.
Drop two lines of unnecessary code.
Change-Id: I8b38f222f1c8c822e8e5e776850dbc60e30e8b8d
---
M src/osmo-bsc/lchan_fsm.c
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index 13ae7ad..28dc846 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -460,8 +460,6 @@
};
lchan->ms_power = ms_pwr_ctl_lvl(bts->band,
bts->ms_max_power);
lchan->bs_power = 0; /* 0dB reduction, output power =
Pn */
- memset(&lchan->mr_ms_lv, 0, sizeof(lchan->mr_ms_lv));
- memset(&lchan->mr_bts_lv, 0, sizeof(lchan->mr_bts_lv));
}
if (info->chan_mode == GSM48_CMODE_SPEECH_AMR)
--
To view, visit https://gerrit.osmocom.org/10699
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b38f222f1c8c822e8e5e776850dbc60e30e8b8d
Gerrit-Change-Number: 10699
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-CC: Pau Espin Pedrol <[email protected]>
