Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10774 )
Change subject: assignment: remove unnecessary call to gsm0808_speech_codec_from_chan_type() ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/10774/1/src/osmo-bsc/assignment_fsm.c File src/osmo-bsc/assignment_fsm.c: https://gerrit.osmocom.org/#/c/10774/1/src/osmo-bsc/assignment_fsm.c@171 PS1, Line 171: /* FIXME: AMR codec configuration must be derived from lchan1! */ Thanks for spotting this! The below call was actually without effect, because it did not assign sc_ptr. But we also have chosen a speech codec for SCCPlite connections. I'm pretty sure above gsm0808_speech_codec_from_chan_type() should be here, outside the "if AoIP". It means that so far we fail to send the chosen speech codec back to the MSC for SCCPlite connections. It is mandatory for IP based user plane, which we use, so definitely needs to be fixed. See 3GPP TS 48.008 3.2.1.2 ASSIGNMENT COMPLETE. https://osmocom.org/issues/3528 -- To view, visit https://gerrit.osmocom.org/10774 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34d9281944b36cd89ad8e1c5774f0ea80fdfadc8 Gerrit-Change-Number: 10774 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Comment-Date: Thu, 06 Sep 2018 11:34:24 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
