Neels Hofmeyr has submitted this change and it was merged. (
https://gerrit.osmocom.org/10774 )
Change subject: assignment: remove unnecessary call to
gsm0808_speech_codec_from_chan_type()
......................................................................
assignment: remove unnecessary call to gsm0808_speech_codec_from_chan_type()
There is a function call to gsm0808_speech_codec_from_chan_type() after
an if construct that checks if we need voice and if we need it if it is
related to an AoIP connection.
However, at the moment we call gsm0808_speech_codec_from_chan_type() all
the time, even when just figured out that we don't need to. Presumably
this is a refactory leftover. Lets remove the excess function call.
Change-Id: I34d9281944b36cd89ad8e1c5774f0ea80fdfadc8
---
M src/osmo-bsc/assignment_fsm.c
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Neels Hofmeyr: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c
index 41615ac..e1da45b 100644
--- a/src/osmo-bsc/assignment_fsm.c
+++ b/src/osmo-bsc/assignment_fsm.c
@@ -171,8 +171,6 @@
/* FIXME: AMR codec configuration must be derived from lchan1!
*/
}
- gsm0808_speech_codec_from_chan_type(&sc, perm_spch);
-
resp = gsm0808_create_ass_compl(lchan->abis_ip.ass_compl.rr_cause,
chosen_channel,
lchan->encr.alg_id, perm_spch,
--
To view, visit https://gerrit.osmocom.org/10774
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I34d9281944b36cd89ad8e1c5774f0ea80fdfadc8
Gerrit-Change-Number: 10774
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
