osmith has posted comments on this change. ( https://gerrit.osmocom.org/11437 )
Change subject: cosmetic: fix spec ref for gsm0808_cipher_mode() ...................................................................... Patch Set 1: > I don't really see where the entire function does anything related to GSM TS > 04.08? It's dealing with BSSAP/BSSMAP which is in 08.08 ?!? Well, originally this said: > GSM 08.08 § 3.4.7 cipher mode handling. So I went looking for that chapter in GSM 08.08, but I could not find it. * GSM 08.08 goes only until 3.3, no 3.4: https://www.etsi.org/deliver/etsi_gts/08/0808/05.12.00_60/gsmts_0808v051200p.pdf * GSM 04.08 has "3.4.7 Ciphering mode setting procedure", page 59 in this PDF: https://www.etsi.org/deliver/etsi_gts/04/0408/05.03.00_60/gsmts_0408v050300p.pdf ...so my conclusion was, that this was meant to point to 04.08 § 3.4.7. What am I missing? -- To view, visit https://gerrit.osmocom.org/11437 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I359caf1dd30f033c0b606040ccf27aa4c5a9d2c6 Gerrit-Change-Number: 11437 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Wed, 24 Oct 2018 08:28:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No