Max has posted comments on this change. ( https://gerrit.osmocom.org/11455 )
Change subject: add osmo_sock_get_{local,remote}_ip{,_port}()
......................................................................
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/11455/1/include/osmocom/core/socket.h
File include/osmocom/core/socket.h:
https://gerrit.osmocom.org/#/c/11455/1/include/osmocom/core/socket.h@59
PS1, Line 59: char *osmo_sock_get_name2(void *ctx, int fd, bool local, bool
port);
If that's meant for internal use (as per comment in .c) than why do we add it
to public API?
https://gerrit.osmocom.org/#/c/11455/1/src/socket.c
File src/socket.c:
https://gerrit.osmocom.org/#/c/11455/1/src/socket.c@714
PS1, Line 714:
There seems to be some code duplication with osmo_sock_get_name() - any chance
to unify that?
--
To view, visit https://gerrit.osmocom.org/11455
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6803c204771c59a2002bc6a0e6b79c83c35f87e1
Gerrit-Change-Number: 11455
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Max <msur...@sysmocom.de>
Gerrit-Comment-Date: Thu, 25 Oct 2018 13:07:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
