Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11605


Change subject: bsc: gsm0808: Fix return code in bsc_compl_l3
......................................................................

bsc: gsm0808: Fix return code in bsc_compl_l3

complete_layer3 returns true if everything succeeded, false otherwise.
However, its caller bsc_compl_l3 returns unix style (0 sucess,
negative error).

This commit has no real effect since only caller of bsc_compl_l3 never
checks return code, but will check it in the future.

Change-Id: I722696c3f6402288b51d6fcf51f478b3b0c9f0f0
---
M src/osmo-bsc/gsm_08_08.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/05/11605/1

diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c
index 19c2598..7e5b909 100644
--- a/src/osmo-bsc/gsm_08_08.c
+++ b/src/osmo-bsc/gsm_08_08.c
@@ -382,7 +382,7 @@
                return -1;
        }

-       return complete_layer3(conn, msg, msc);
+       return complete_layer3(conn, msg, msc) ? 0 : -1;
 }

 static int handle_page_resp(struct gsm_subscriber_connection *conn, struct 
msgb *msg)

--
To view, visit https://gerrit.osmocom.org/11605
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I722696c3f6402288b51d6fcf51f478b3b0c9f0f0
Gerrit-Change-Number: 11605
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <[email protected]>

Reply via email to